perf(keyboard): track KeyboardState per property with @Observable

- KeyboardState moves from ObservableObject/@Published to @Observable, so a view re-renders only for the properties it reads. Previously unpublished state and injected action hooks are @ObservationIgnored.
- KeyboardViewController replaces the $phase/$surface Combine sinks with Observations loops tied to the same cancellables.
- AIKeyboardView reads the 200 ms mic level and live ASR partials in small child views (AssistantWaveform, LiveTranscriptReader), so those ticks no longer rebuild the whole assistant surface.
- Tests observe changes with withObservationTracking instead of Combine publishers.
This commit is contained in:
2026-10-21 06:12:21 +02:00
parent 6e64f96dce
commit cfe14f67d4
17 changed files with 220 additions and 173 deletions
+7 -9
View File
@@ -13,7 +13,7 @@
// *don't* attempt that here — the State class is what we care about
// for correctness.
import Combine
import Observation
@testable import OSGKeyboardShared
import XCTest
@@ -189,19 +189,17 @@ final class KeyboardStateTests: XCTestCase {
)
state.enabledClipboardSkills = [first]
let published = expectation(description: "resolved skill snapshot published")
var cancellable: AnyCancellable?
cancellable = state.$enabledClipboardSkills
.dropFirst()
.sink { skills in
XCTAssertEqual(skills.first?.customPrompt, "Second prompt")
published.fulfill()
}
withObservationTracking {
_ = state.enabledClipboardSkills
} onChange: {
published.fulfill()
}
state.enabledClipboardSkills = [second]
wait(for: [published], timeout: 1)
XCTAssertEqual(state.enabledClipboardSkills.first?.customPrompt, "Second prompt")
XCTAssertEqual(state.enabledClipboardSkillIDs, ["official.rewrite"])
withExtendedLifetime(cancellable) {}
}
func testReturnKeyRoleActionFillAndTitles() {