Remove manual polish scenario UI; rely on auto AppContext only

- Hide AppContext chip and remove manual override from keyboard
- Remove polish scenario picker and custom system prompt from settings
- Remove scenario section from onboarding
- Translation prompt uses auto-detected AppContext instead of polish scenario
- Delete ScenarioPrompt, ScenarioStyleDirective, PolishScenario, and related views

Co-authored-by: Rocky <hkgood@users.noreply.github.com>

OSGKeyboardShared/Models/PolishScenario.swift

@@ -1,55 +0,0 @@
-// PolishScenario.swift
-// OSGKeyboard · Shared
-//
-// Curated polish scenarios the user picks instead of editing a raw
-// system prompt. Display names live in Shared.strings; prompt bodies
-// are built by `ScenarioPrompt.make`.
-
-import Foundation
-
-public struct PolishScenario: Identifiable, Hashable, Sendable {
-    public let id: String
-    /// Shared.strings key for the picker label.
-    public let labelKey: String
-    /// Shared.strings key for the compact keyboard chip label.
-    public let chipLabelKey: String
-
-    public init(id: String, labelKey: String, chipLabelKey: String) {
-        self.id = id
-        self.labelKey = labelKey
-        self.chipLabelKey = chipLabelKey
-    }
-}
-
-public enum PolishScenarioCatalog {
-    public static let defaultId = "daily_chat"
-    public static let customId = "custom"
-
-    /// Order matters — picker / chip render top-to-bottom.
-    public static let all: [PolishScenario] = [
-        PolishScenario(id: "daily_chat", labelKey: "polishScenario.daily_chat", chipLabelKey: "polishScenario.chip.daily_chat"),
-        PolishScenario(id: "social_lifestyle", labelKey: "polishScenario.social_lifestyle", chipLabelKey: "polishScenario.chip.social_lifestyle"),
-        PolishScenario(id: "social_short", labelKey: "polishScenario.social_short", chipLabelKey: "polishScenario.chip.social_short"),
-        PolishScenario(id: "goofy", labelKey: "polishScenario.goofy", chipLabelKey: "polishScenario.chip.goofy"),
-        PolishScenario(id: "work", labelKey: "polishScenario.work", chipLabelKey: "polishScenario.chip.work"),
-        PolishScenario(id: "document", labelKey: "polishScenario.document", chipLabelKey: "polishScenario.chip.document"),
-        PolishScenario(id: "todo", labelKey: "polishScenario.todo", chipLabelKey: "polishScenario.chip.todo"),
-        PolishScenario(id: customId, labelKey: "polishScenario.custom", chipLabelKey: "polishScenario.chip.custom"),
-    ]
-
-    public static func isCustom(_ id: String) -> Bool {
-        id == customId
-    }
-
-    public static func resolve(_ id: String) -> PolishScenario {
-        all.first { $0.id == id } ?? all.first { $0.id == defaultId } ?? all[0]
-    }
-
-    public static func displayName(for id: String, language: AppUILanguage? = nil) -> String {
-        SharedL10n.string(resolve(id).labelKey, language: language)
-    }
-
-    public static func chipLabel(for id: String, language: AppUILanguage? = nil) -> String {
-        SharedL10n.string(resolve(id).chipLabelKey, language: language)
-    }
-}

OSGKeyboardShared/Models/ProviderConfig.swift

@@ -23,7 +23,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         // delete the entry, but no other code path touches this key.
         static let apiKeyLegacy    = "config.apiKey"
         static let model           = "config.model"
-        static let systemPrompt    = "config.systemPrompt"
         static let modeId          = "config.modeId"
         static let localeId        = "config.localeId"
         static let engineMode       = "config.engineMode"
@@ -51,7 +50,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         // who upgraded from a build that wrote it don't see a flash of
         // "on" state during init, but new writes never touch the key.
         static let translationTargetLocaleId = "config.translationTargetLocaleId"
-        static let polishScenarioId = "config.polishScenarioId"
         static let handednessPreference = "config.handednessPreference"
         // v0.3.0: how aggressively the LLM should rewrite transcripts.
         static let polishIntensity = "config.polishIntensity"
@@ -80,9 +78,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
     @Published public var model: String {
         didSet { defaults.set(model, forKey: Key.model) }
     }
-    @Published public var systemPrompt: String {
-        didSet { defaults.set(systemPrompt, forKey: Key.systemPrompt) }
-    }
     @Published public var modeId: String {
         didSet { defaults.set(modeId, forKey: Key.modeId) }
     }
@@ -158,14 +153,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
             AppGroupConfigDarwin.postConfigChanged()
         }
     }
-    /// Selected polish scenario preset (e.g. `daily_chat`, `work`) or
-    /// `custom` when the user edits the raw system prompt.
-    @Published public var polishScenarioId: String {
-        didSet {
-            defaults.set(polishScenarioId, forKey: Key.polishScenarioId)
-            AppGroupConfigDarwin.postConfigChanged()
-        }
-    }
     /// Which hand the user holds the phone with — mirrors to the keyboard
     /// extension so delete / return can swap on the bottom row.
     @Published public var handednessPreference: HandednessPreference {
@@ -192,17 +179,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         return isLocalEngine && localModeCloudPolishEnabled
     }
 
-    /// Polish scenario picker visibility — same gate as translation:
-    /// only when the pipeline can run a cloud LLM step.
-    public var isPolishScenarioRowVisible: Bool {
-        if engineMode == "cloud" { return true }
-        return isLocalEngine && localModeCloudPolishEnabled
-    }
-
-    public var isCustomPolishScenario: Bool {
-        PolishScenarioCatalog.isCustom(polishScenarioId)
-    }
-
     /// v0.3.0: how aggressively the LLM should rewrite the ASR
     /// transcript. Default is `medium` (Typeless-equivalent). The
     /// `off` value never calls the LLM — equivalent to "transcribe
@@ -249,12 +225,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         isLocalEngine ? "deepseek" : providerId
     }
 
-    /// The system prompt the user *sees* in the editor — fall back to the
-    /// provider-aware default from `AppGroupStore` when nothing is set.
-    public var defaultSystemPrompt: String {
-        AppGroupStore.defaultSystemPrompt(for: providerId)
-    }
-
     private let defaults: UserDefaults
 
     public init(defaults: UserDefaults? = nil) {
@@ -272,8 +242,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         self.apiKey = ProviderConfig.resolveAPIKey(defaults: resolvedDefaults)
 
         self.model        = resolvedDefaults.string(forKey: Key.model)      ?? preset.defaultModel
-        self.systemPrompt = resolvedDefaults.string(forKey: Key.systemPrompt)
-            ?? AppGroupStore.defaultSystemPrompt(for: pid)
         self.modeId          = resolvedDefaults.string(forKey: Key.modeId)     ?? "polish"
         self.localeId        = resolvedDefaults.string(forKey: Key.localeId)   ?? "auto"
         self.engineMode       = resolvedDefaults.string(forKey: Key.engineMode) ?? "cloud"
@@ -307,17 +275,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         // conservative default that matches the picker / chip UX).
         self.translationTargetLocaleId = resolvedDefaults.string(forKey: Key.translationTargetLocaleId)
             ?? TranslationLanguageCatalog.offLocaleId
-        if let storedScenario = resolvedDefaults.string(forKey: Key.polishScenarioId) {
-            self.polishScenarioId = PolishScenarioCatalog.resolve(storedScenario).id
-        } else {
-            let savedPrompt = resolvedDefaults.string(forKey: Key.systemPrompt)
-                ?? AppGroupStore.defaultSystemPrompt(for: pid)
-            if savedPrompt != AppGroupStore.defaultSystemPrompt(for: pid) {
-                self.polishScenarioId = PolishScenarioCatalog.customId
-            } else {
-                self.polishScenarioId = PolishScenarioCatalog.defaultId
-            }
-        }
         self.handednessPreference = HandednessPreference.fromStored(
             resolvedDefaults.string(forKey: Key.handednessPreference)
         )
@@ -353,10 +310,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
     }
 
     public func apply(preset: LLMProvider) {
-        // Capture the *previous* provider id BEFORE we mutate, so the
-        // system-prompt reset check below can compare against the actual
-        // prior default.
-        let oldId = providerId
         providerId = preset.id
         if !preset.defaultBaseURL.isEmpty {
             baseURL = preset.defaultBaseURL
@@ -364,13 +317,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         if !preset.defaultModel.isEmpty {
             model = preset.defaultModel
         }
-        // When switching providers, reset the system prompt to the new
-        // provider's default — otherwise the user is left editing a
-        // Chinese prompt on a US-English model.
-        if systemPrompt.isEmpty
-            || systemPrompt == AppGroupStore.defaultSystemPrompt(for: oldId) {
-            systemPrompt = AppGroupStore.defaultSystemPrompt(for: preset.id)
-        }
     }
 
     public func reset() {
@@ -379,8 +325,6 @@ public final class ProviderConfig: ObservableObject, @unchecked Sendable {
         baseURL = preset.defaultBaseURL
         apiKey = ""
         model = preset.defaultModel
-        systemPrompt = AppGroupStore.defaultSystemPrompt(for: "openai")
-        polishScenarioId = PolishScenarioCatalog.defaultId
         handednessPreference = .left
         hasAcknowledgedCloudSharing = false
     }