feat(keyboard): improve typing, voice flow, and polish reliability
Reduce extension memory pressure and delivery races while adding richer candidates, tactile feedback, and safer two-level creative polishing.
This commit is contained in:
Rocky
@@ -0,0 +1,289 @@
|
||||
// FlowKeyboardPoliciesTests.swift
|
||||
// OSGKeyboardTests
|
||||
//
|
||||
// Hermetic regression coverage for keyboard↔host Flow decision helpers.
|
||||
|
||||
import XCTest
|
||||
@testable import OSGKeyboardShared
|
||||
|
||||
final class FlowKeyboardPoliciesTests: XCTestCase {
|
||||
|
||||
// MARK: - Host warming
|
||||
|
||||
func testHostBusyReasonIsNotPreparingSession() {
|
||||
XCTAssertTrue(FlowKeyboardHostWarming.isHostBusy(reason: .recording))
|
||||
XCTAssertTrue(FlowKeyboardHostWarming.isHostBusy(reason: .processing))
|
||||
XCTAssertTrue(FlowKeyboardHostWarming.isHostBusy(reason: .awaitingDelivery))
|
||||
XCTAssertFalse(FlowKeyboardHostWarming.isHostBusy(reason: .starting))
|
||||
XCTAssertFalse(FlowKeyboardHostWarming.isHostBusy(reason: .ready))
|
||||
|
||||
let warming = FlowKeyboardHostWarming.isHostWarming(
|
||||
hostReady: false,
|
||||
hostBusy: true,
|
||||
sessionActive: true,
|
||||
hostReachable: true,
|
||||
isPendingFlowStart: false,
|
||||
withinReadyGrace: false,
|
||||
snapshotReason: .recording
|
||||
)
|
||||
XCTAssertFalse(warming, "busy must not look like preparing/starting")
|
||||
}
|
||||
|
||||
func testStartingReasonWithActiveSessionIsPreparing() {
|
||||
let warming = FlowKeyboardHostWarming.isHostWarming(
|
||||
hostReady: false,
|
||||
hostBusy: false,
|
||||
sessionActive: true,
|
||||
hostReachable: false,
|
||||
isPendingFlowStart: false,
|
||||
withinReadyGrace: false,
|
||||
snapshotReason: .starting
|
||||
)
|
||||
XCTAssertTrue(warming)
|
||||
}
|
||||
|
||||
// MARK: - Adopt busy
|
||||
|
||||
func testReAdoptsRecordingAfterExtensionProcessLoss() {
|
||||
let sessionId = UUID()
|
||||
let utteranceId = UUID()
|
||||
let snapshot = FlowReadySnapshot(
|
||||
sessionId: sessionId,
|
||||
ready: false,
|
||||
reason: .recording,
|
||||
engineMode: "cloud",
|
||||
localeId: "zh-Hans",
|
||||
busyUtteranceId: utteranceId,
|
||||
hostGeneration: "gen-1"
|
||||
)
|
||||
let action = FlowKeyboardAdoptBusyPolicy.decide(
|
||||
snapshot: snapshot,
|
||||
currentHostGeneration: "gen-1",
|
||||
isFlowRecording: false,
|
||||
isAwaitingFlowResult: false,
|
||||
lastConsumedUtteranceId: nil,
|
||||
lastStoppedUtteranceId: nil
|
||||
)
|
||||
XCTAssertEqual(
|
||||
action,
|
||||
.adoptRecording(sessionId: sessionId, utteranceId: utteranceId)
|
||||
)
|
||||
}
|
||||
|
||||
func testIgnoresConsumedAndStoppedUtteranceIds() {
|
||||
let sessionId = UUID()
|
||||
let utteranceId = UUID()
|
||||
let snapshot = FlowReadySnapshot(
|
||||
sessionId: sessionId,
|
||||
ready: false,
|
||||
reason: .recording,
|
||||
engineMode: "cloud",
|
||||
localeId: "zh-Hans",
|
||||
busyUtteranceId: utteranceId,
|
||||
hostGeneration: "gen-1"
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowKeyboardAdoptBusyPolicy.decide(
|
||||
snapshot: snapshot,
|
||||
currentHostGeneration: "gen-1",
|
||||
isFlowRecording: false,
|
||||
isAwaitingFlowResult: false,
|
||||
lastConsumedUtteranceId: utteranceId,
|
||||
lastStoppedUtteranceId: nil
|
||||
),
|
||||
.none
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowKeyboardAdoptBusyPolicy.decide(
|
||||
snapshot: snapshot,
|
||||
currentHostGeneration: "gen-1",
|
||||
isFlowRecording: false,
|
||||
isAwaitingFlowResult: false,
|
||||
lastConsumedUtteranceId: nil,
|
||||
lastStoppedUtteranceId: utteranceId
|
||||
),
|
||||
.none
|
||||
)
|
||||
}
|
||||
|
||||
func testIgnoresDeadHostGenerationSnapshot() {
|
||||
let snapshot = FlowReadySnapshot(
|
||||
sessionId: UUID(),
|
||||
ready: false,
|
||||
reason: .recording,
|
||||
engineMode: "cloud",
|
||||
localeId: "zh-Hans",
|
||||
busyUtteranceId: UUID(),
|
||||
hostGeneration: "old-gen"
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowKeyboardAdoptBusyPolicy.decide(
|
||||
snapshot: snapshot,
|
||||
currentHostGeneration: "live-gen",
|
||||
isFlowRecording: false,
|
||||
isAwaitingFlowResult: false,
|
||||
lastConsumedUtteranceId: nil,
|
||||
lastStoppedUtteranceId: nil
|
||||
),
|
||||
.none
|
||||
)
|
||||
}
|
||||
|
||||
func testClearsStickyProcessingWhenHostNoLongerBusy() {
|
||||
let snapshot = FlowReadySnapshot(
|
||||
sessionId: UUID(),
|
||||
ready: true,
|
||||
reason: .ready,
|
||||
engineMode: "cloud",
|
||||
localeId: "zh-Hans"
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowKeyboardAdoptBusyPolicy.decide(
|
||||
snapshot: snapshot,
|
||||
currentHostGeneration: nil,
|
||||
isFlowRecording: false,
|
||||
isAwaitingFlowResult: false,
|
||||
lastConsumedUtteranceId: nil,
|
||||
lastStoppedUtteranceId: nil
|
||||
),
|
||||
.clearStickyProcessing
|
||||
)
|
||||
}
|
||||
|
||||
// MARK: - Result matcher
|
||||
|
||||
func testMatchingResultRequiresAlignedSessionAndUtterance() {
|
||||
let sessionId = UUID()
|
||||
let utteranceId = UUID()
|
||||
let result = FlowResult(
|
||||
sessionId: sessionId,
|
||||
utteranceId: utteranceId,
|
||||
commandSeq: 1,
|
||||
status: .final,
|
||||
text: "ok"
|
||||
)
|
||||
XCTAssertNotNil(
|
||||
FlowKeyboardResultMatcher.matchingResult(
|
||||
latest: result,
|
||||
activeSessionId: sessionId,
|
||||
currentUtteranceId: utteranceId
|
||||
)
|
||||
)
|
||||
XCTAssertNil(
|
||||
FlowKeyboardResultMatcher.matchingResult(
|
||||
latest: result,
|
||||
activeSessionId: UUID(),
|
||||
currentUtteranceId: utteranceId
|
||||
)
|
||||
)
|
||||
XCTAssertNil(
|
||||
FlowKeyboardResultMatcher.matchingResult(
|
||||
latest: result,
|
||||
activeSessionId: sessionId,
|
||||
currentUtteranceId: UUID()
|
||||
)
|
||||
)
|
||||
}
|
||||
|
||||
func testTerminalFailureStatuses() {
|
||||
let base = FlowResult(
|
||||
sessionId: UUID(),
|
||||
utteranceId: UUID(),
|
||||
commandSeq: 1,
|
||||
status: .final
|
||||
)
|
||||
XCTAssertFalse(FlowKeyboardResultMatcher.isTerminalFailure(base))
|
||||
XCTAssertTrue(
|
||||
FlowKeyboardResultMatcher.isTerminalFailure(
|
||||
FlowResult(
|
||||
sessionId: base.sessionId,
|
||||
utteranceId: base.utteranceId,
|
||||
commandSeq: 1,
|
||||
status: .error
|
||||
)
|
||||
)
|
||||
)
|
||||
XCTAssertTrue(
|
||||
FlowKeyboardResultMatcher.isTerminalFailure(
|
||||
FlowResult(
|
||||
sessionId: base.sessionId,
|
||||
utteranceId: base.utteranceId,
|
||||
commandSeq: 1,
|
||||
status: .timeout
|
||||
)
|
||||
)
|
||||
)
|
||||
XCTAssertTrue(
|
||||
FlowKeyboardResultMatcher.isTerminalFailure(
|
||||
FlowResult(
|
||||
sessionId: base.sessionId,
|
||||
utteranceId: base.utteranceId,
|
||||
commandSeq: 1,
|
||||
status: .aborted
|
||||
)
|
||||
)
|
||||
)
|
||||
}
|
||||
|
||||
// MARK: - Command gate
|
||||
|
||||
func testIgnoresStaleSessionAndNonIncreasingSeq() {
|
||||
let sessionId = UUID()
|
||||
XCTAssertEqual(
|
||||
FlowCommandGatekeeper.decide(
|
||||
commandSessionId: UUID(),
|
||||
commandSeq: 2,
|
||||
activeSessionId: sessionId,
|
||||
lastHandledCommandSeq: 1
|
||||
),
|
||||
.rejectWrongSession
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowCommandGatekeeper.decide(
|
||||
commandSessionId: sessionId,
|
||||
commandSeq: 1,
|
||||
activeSessionId: sessionId,
|
||||
lastHandledCommandSeq: 1
|
||||
),
|
||||
.rejectStaleSeq
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowCommandGatekeeper.decide(
|
||||
commandSessionId: sessionId,
|
||||
commandSeq: 2,
|
||||
activeSessionId: sessionId,
|
||||
lastHandledCommandSeq: 1
|
||||
),
|
||||
.accept
|
||||
)
|
||||
}
|
||||
|
||||
// MARK: - Orphan reconcile
|
||||
|
||||
func testClearsOrphanedRecordingStateWhenHostInactive() {
|
||||
XCTAssertEqual(
|
||||
FlowOrphanRecordingReconciler.decide(
|
||||
isHostStale: false,
|
||||
isActive: false,
|
||||
recordingState: .recording
|
||||
),
|
||||
.clearOrphanedRecording(.recording)
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowOrphanRecordingReconciler.decide(
|
||||
isHostStale: true,
|
||||
isActive: false,
|
||||
recordingState: .idle
|
||||
),
|
||||
.clearZombieSession
|
||||
)
|
||||
XCTAssertEqual(
|
||||
FlowOrphanRecordingReconciler.decide(
|
||||
isHostStale: false,
|
||||
isActive: true,
|
||||
recordingState: .recording
|
||||
),
|
||||
.none
|
||||
)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user